diff --git a/android/app/src/main/java/io/narl/protonstream/ui/SettingsScreen.kt b/android/app/src/main/java/io/narl/protonstream/ui/SettingsScreen.kt index b779d0a..d16d7a5 100644 --- a/android/app/src/main/java/io/narl/protonstream/ui/SettingsScreen.kt +++ b/android/app/src/main/java/io/narl/protonstream/ui/SettingsScreen.kt @@ -91,6 +91,9 @@ internal fun SettingsScreen( onRemoveAllOffline: () -> Unit, padding: PaddingValues, initialPage: SettingsPage? = null, + // A parameter so the screenshot tests can pin it: read from the package, + // every version bump changed the committed image of this page. + version: String = appVersion(), ) { val context = LocalContext.current val settings = remember { SettingsStore(context) } @@ -145,7 +148,7 @@ internal fun SettingsScreen( } else { "Off" } - SettingsPage.About -> "Version ${appVersion()} · licences" + SettingsPage.About -> "Version $version · licences" }, ) }, @@ -286,7 +289,7 @@ internal fun SettingsScreen( SettingsPage.About -> SettingsSubPage(SettingsPage.About, padding, back) { ListItem( headlineContent = { Text("Proton Stream") }, - supportingContent = { Text("Version ${appVersion()}") }, + supportingContent = { Text("Version $version") }, colors = ListItemDefaults.colors(containerColor = Color.Transparent), ) SettingAction("Licence", "GPL-3.0-or-later. Comes with absolutely no warranty.") { diff --git a/android/app/src/test/java/io/narl/protonstream/ui/ScreenshotTest.kt b/android/app/src/test/java/io/narl/protonstream/ui/ScreenshotTest.kt index 2e53501..16a6cb2 100644 --- a/android/app/src/test/java/io/narl/protonstream/ui/ScreenshotTest.kt +++ b/android/app/src/test/java/io/narl/protonstream/ui/ScreenshotTest.kt @@ -139,7 +139,7 @@ class ScreenshotTest { @Test fun `the settings page`() = capture("settings-phone") { - SettingsScreen(LIBRARY, { _, _, _, _ -> }, {}, {}, {}, PaddingValues()) + SettingsScreen(LIBRARY, { _, _, _, _ -> }, {}, {}, {}, PaddingValues(), version = "1.0.0") } @Test diff --git a/android/app/src/test/screenshots/settings-phone.png b/android/app/src/test/screenshots/settings-phone.png index 024e501..b7c995f 100644 Binary files a/android/app/src/test/screenshots/settings-phone.png and b/android/app/src/test/screenshots/settings-phone.png differ