From ee76f4ac60d7b630dcc03b93b11e5876e30b67bb Mon Sep 17 00:00:00 2001 From: Nils Pukropp Date: Mon, 12 Oct 2026 00:06:51 +0200 Subject: [PATCH] fix(packaging): recommend each keyring only on its own desktop The RPM recommended both gnome-keyring and kwallet unconditionally, and dnf installs weak dependencies by default, so a GNOME install on Fedora pulled in KWallet and KDE Frameworks with it. The recommendations are now rich dependencies: KWallet only with plasma-workspace, GNOME Keyring only without it, and the AppIndicator extension only with gnome-shell. RPM does not accept `unless` in a weak dependency, so the keyring uses the equivalent `(gnome-keyring or plasma-workspace)`. Reported on Reddit by a Fedora GNOME user. --- docs/CHANGELOG.md | 5 +++++ packaging/proton-drive-linux.spec | 10 ++++++---- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index c279442..fded422 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -17,6 +17,11 @@ scratch (user data in `staging/` and `recovery/` is never touched by this). it. See [Install → Binary cache](INSTALL.md#binary-cache). ([#37](https://github.com/narrrl/proton-drive-linux/issues/37)) +### Fixed +- **The Fedora package installed KDE packages on GNOME.** Its recommendation of KWallet is now + only for Plasma, the GNOME keyring only for desktops other than Plasma, and the AppIndicator + extension only for GNOME. + ## [3.3.0] — 2026-10-11 Schema: **42**, unchanged. diff --git a/packaging/proton-drive-linux.spec b/packaging/proton-drive-linux.spec index 35bdda7..7c88d6b 100644 --- a/packaging/proton-drive-linux.spec +++ b/packaging/proton-drive-linux.spec @@ -37,11 +37,13 @@ Requires: webkitgtk6.0 Requires: perl-Image-ExifTool Requires: xdg-utils -# DE-specific; do not Require a single desktop environment. -Recommends: gnome-keyring +# DE-specific; do not Require a single desktop environment. dnf installs weak +# dependencies by default, so each is conditional on its own desktop: a plain +# `Recommends: kwallet` pulled KDE Frameworks onto GNOME installs. +Recommends: (gnome-keyring or plasma-workspace) Recommends: iso-codes -Recommends: gnome-shell-extension-appindicator -Recommends: kwallet +Recommends: (gnome-shell-extension-appindicator if gnome-shell) +Recommends: (kwallet if plasma-workspace) # Only for `pdfs-prompt --fzf`; every other front end works without them. Suggests: fzf