mirror of
https://github.com/narrrl/proton-drive-linux.git
synced 2026-11-03 16:41:26 +01:00
fix(core): drop a rename replaced while its failure was being recorded (B158)
B141 drops a rename that fails with a newer one queued behind it. The worker records the failure and releases its claim in two steps, and a rename queued between them waited behind the old one, which was kept with a backoff. Released, the old one was not due and the new one was, so the new one landed first and the old one then put the first name back. Releasing the claim now drops the old rename too when a newer one is queued, and both checks match the node by local id as well as by uid.
This commit is contained in:
1 parent
4676a4e32b
commit
c2f93449ad
5 files changed
+67
-13
No files matched your search
@@ -12,6 +12,31 @@ Conventions:
|
||||
|
||||
---
|
||||
|
||||
## B158 — A file renamed twice in a row ends up under the first name, again
|
||||
|
||||
**Status:** Fixed (unverified).
|
||||
**Found:** 2026-10-04, by the simulation's Wi-Fi profile (`one_client_on_a_slow_link`, seed 3,
|
||||
four of ten runs on 4676a4e). A file was renamed to `b.txt`, whose name a create on the wire
|
||||
still held, and then to `e.md`. Drive renamed it to `e.md` and then back to `b.txt`. The
|
||||
liveness check found `b.txt` on Drive and `e.md` in the mount.
|
||||
|
||||
**Where:** `Db::record_op_failure` and `Db::release_op_claim` in
|
||||
`crates/pdfs-core/src/db/ops.rs`.
|
||||
|
||||
**Cause.** B141's fix drops a rename that fails while a newer one is queued behind it. The worker
|
||||
records the failure first and releases its claim after that. The second rename came in between:
|
||||
the first was still claimed, so the second queued behind it, but the failure had already been
|
||||
recorded with nothing behind it, so the first was kept with a backoff. Once released, it was not
|
||||
due and the second was, so the second landed first. More workers made the gap easier to hit.
|
||||
|
||||
**Fix.** Releasing the claim of a rename drops it as well when a newer rename of the same node is
|
||||
queued behind it. Both checks match the node by local id as well as by uid.
|
||||
|
||||
**Test:** unit test `a_rename_on_the_wire_lands_before_the_one_that_replaces_it`, extended.
|
||||
Seeds 2 and 3 of `one_client_on_a_slow_link` pass eight replays each.
|
||||
|
||||
---
|
||||
|
||||
## B157 — A second write to a file whose upload was not read back fails with `EIO`
|
||||
|
||||
**Status:** Fixed (unverified).
|
||||
|
||||
@@ -44,6 +44,8 @@ by its local id, in the queue, the stored tree and pins alike.
|
||||
of itself when the link lost Drive's answer to the first try** (B156).
|
||||
- **Writing to a file twice in a row no longer fails with "Input/output error" when the link
|
||||
lost Drive's answer to reading back the file's last upload** (B157).
|
||||
- **A file renamed twice in a row, while the first name was still taken, keeps the second name**
|
||||
(B158).
|
||||
- **A file renamed just as its upload finished keeps its new name.** The mount no longer showed
|
||||
the old name, and a second rename no longer failed with "No such file or directory" (B152).
|
||||
- **A change that waits for a name to be freed no longer waits seconds after it is.** A rename or
|
||||
|
||||
@@ -9,7 +9,7 @@ Tracks `docs/MILESTONE-3.0.0.md`. Update it with every commit that moves a phase
|
||||
- **Phase 2**: local ids, inode = local id, one tree for every mount (2.10.0).
|
||||
- **Phase 3, first part**: mkdir, create, rename, unlink and rmdir on the mount are recorded
|
||||
locally and sent from the queue; `"local_first": false` brings back the old path (5e0f30c).
|
||||
- Fixes from the simulation and account runs since then: B127 and B141 to B157.
|
||||
- Fixes from the simulation and account runs since then: B127 and B141 to B158.
|
||||
- **Sync issues, first cut** (§6.2): refusals sorted into issues, shown at once in the app,
|
||||
tray and CLI; Export button and `pdfs sync export`; `pdfs sync issues`.
|
||||
|
||||
@@ -81,7 +81,8 @@ Tracks `docs/MILESTONE-3.0.0.md`. Update it with every commit that moves a phase
|
||||
it may be B152. Replays of slow-link seed 4 failed two of six times on a file written
|
||||
again after its create lost its answer (B156, fixed). With sixteen drain workers
|
||||
(16fca10), seed 4 failed every replay on a write after an upload that was not read
|
||||
back (B157, fixed).
|
||||
back (B157, fixed). Seed 3 then failed four of ten runs on two renames of one file
|
||||
landing out of order (B158, fixed).
|
||||
- [ ] Known-bug list in `sim/run.rs` is empty: B125 and B130 open; B127, B129 and B132 fixed
|
||||
but unconfirmed.
|
||||
- [ ] A clean account run. The one on a6f36d5 (2026-10-04, LAN: 427 passed, 12 failed)
|
||||
|
||||
Reference in new issue
Block a user