From 5557aa66d554941e6cefabb07ce3f663bd4a17c3 Mon Sep 17 00:00:00 2001 From: Nils Pukropp Date: Fri, 16 Oct 2026 11:58:56 +0200 Subject: [PATCH] ci: run the simulations on pull requests and lint with --locked --- .github/workflows/ci.yml | 5 +++-- docs/TESTING.md | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c5b54f7..be30d78 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -45,7 +45,7 @@ jobs: run: cargo fmt --all -- --check - name: Lints - run: cargo clippy --workspace --all-targets -- -D warnings + run: cargo clippy --workspace --all-targets --locked -- -D warnings - name: Unit tests run: cargo test --workspace --locked @@ -66,8 +66,9 @@ jobs: # The seeded simulation runs (docs/TESTING.md): real FUSE # daemons against an in-memory Drive, so they need /dev/fuse but no account. + # They run on pull requests too: most data-loss fixes are only exercised + # here, and a change that breaks one should not reach main first. simulation: - if: github.event_name != 'pull_request' runs-on: ubuntu-24.04 timeout-minutes: 30 diff --git a/docs/TESTING.md b/docs/TESTING.md index 8b9036e..c0c15f5 100644 --- a/docs/TESTING.md +++ b/docs/TESTING.md @@ -5,7 +5,7 @@ Three layers check the client, from fast and offline to slow and against a real | Layer | Needs | Runs in CI | |---|---|---| | [Unit tests](#unit-tests) | Nothing | Every push and pull request | -| [Simulation runs](#simulation-runs) | `/dev/fuse` | Every push to `main` | +| [Simulation runs](#simulation-runs) | `/dev/fuse` | Every push to `main` and every pull request | | [Acceptance suite](#acceptance-suite) | Nothing for the reference run; a signed-in account for the rest | The reference run only | ## Unit tests