fixed dangerous states to be applied

src/sal/heuristic/discovery.rs

@@ -1,11 +1,11 @@
 use std::fs;
 use std::path::{Path, PathBuf};
-use std::process::Command;
 use std::time::{Duration};
 use std::thread;
 use std::sync::mpsc;
 use std::collections::HashMap;
 use crate::sal::heuristic::schema::{SensorDiscovery, ActuatorDiscovery, Conflict, Discovery, Benchmarking};
+use crate::sys::SyscallRunner;
 use tracing::{debug, warn};
 
 /// Registry of dynamically discovered paths for configs and tools.
@@ -31,6 +31,7 @@ pub struct SystemFactSheet {
 /// Probes the system for hardware sensors, actuators, service conflicts, and paths.
 pub fn discover_facts(
     base_path: &Path,
+    runner: &dyn SyscallRunner,
     discovery: &Discovery,
     conflicts: &[Conflict],
     bench_config: Benchmarking,
@@ -45,7 +46,7 @@ pub fn discover_facts(
     let mut active_conflicts = Vec::new();
     for conflict in conflicts {
         for service in &conflict.services {
-            if is_service_active(service) {
+            if is_service_active(runner, service) {
                 debug!("Detected active conflict: {} (Service: {})", conflict.id, service);
                 active_conflicts.push(conflict.id.clone());
                 break;
@@ -93,7 +94,6 @@ fn discover_paths(base_path: &Path, discovery: &Discovery) -> PathRegistry {
                 break;
             }
         }
-        // If not found, use the first one as default if any exist
         if !registry.configs.contains_key(id) {
             if let Some(first) = candidates.first() {
                 registry.configs.insert(id.clone(), PathBuf::from(first));
@@ -142,7 +142,6 @@ fn discover_hwmon(base_path: &Path, cfg: &SensorDiscovery) -> (Option<PathBuf>,
             for hw_entry in hw_entries.flatten() {
                 let file_name = hw_entry.file_name().into_string().unwrap_or_default();
                 
-                // Temperature Sensors
                 if file_name.starts_with("temp") && file_name.ends_with("_label") {
                     if let Some(label) = read_sysfs_with_timeout(&hw_entry.path(), Duration::from_millis(100)) {
                         if cfg.temp_labels.iter().any(|l| label.contains(l)) {
@@ -154,7 +153,6 @@ fn discover_hwmon(base_path: &Path, cfg: &SensorDiscovery) -> (Option<PathBuf>,
                     }
                 }
 
-                // Fan Sensors
                 if file_name.starts_with("fan") && file_name.ends_with("_label") {
                     if let Some(label) = read_sysfs_with_timeout(&hw_entry.path(), Duration::from_millis(100)) {
                         if cfg.fan_labels.iter().any(|l| label.contains(l)) {
@@ -206,18 +204,9 @@ fn discover_rapl(base_path: &Path, cfg: &ActuatorDiscovery) -> Vec<PathBuf> {
     paths
 }
 
-/// Checks if a systemd service is currently active.
-pub fn is_service_active(service: &str) -> bool {
-    let status = Command::new("systemctl")
-        .arg("is-active")
-        .arg("--quiet")
-        .arg(service)
-        .status();
-
-    match status {
-        Ok(s) => s.success(),
-        Err(_) => false,
-    }
+/// Checks if a systemd service is currently active using the injected runner.
+pub fn is_service_active(runner: &dyn SyscallRunner, service: &str) -> bool {
+    runner.run("systemctl", &["is-active", "--quiet", service]).is_ok()
 }
 
 /// Helper to read a sysfs file with a timeout.

src/sal/heuristic/engine.rs

@@ -24,7 +24,7 @@ impl HeuristicEngine {
             .context("Failed to parse hardware_db.toml")?;
 
         // 2. Discover Facts
-        let facts = discover_facts(&ctx.sysfs_base, &db.discovery, &db.conflicts, db.benchmarking.clone());
+        let facts = discover_facts(&ctx.sysfs_base, ctx.runner.as_ref(), &db.discovery, &db.conflicts, db.benchmarking.clone());
         info!("System Identity: {} {}", facts.vendor, facts.model);
 
         // 3. Routing Logic